Good day everyone!
I want to ask everyone here to review the new upcoming code.
Current revision now is 263.
I think main developers may pause merging to main branch for that review time.
Also I hope someone of moderators will create a separate thread on code section on forum with name like "1.1 code review" or "1.1 Bug fix".
Why do we need this?
Some of us think that Tequila can do the job by himself all alone and we'll get good working code to new year holidays.
But just imagine what he really does - he need to take care of all 1.0 features to add ioQuake ones and not broke anything.
ioQuake has a lot of improvements compare to vanilla Q3.
Smoking guns 1.0 has not less than ioQ3.
It is a huge work by many peoples.
And therefore the mistake probability is very high.
If you really like the game you may took some responsibility for it.
Anyway I'm not insist if you don't agree with me - just ignore the thread.
What do I need to know if I want to review?
Basic knowledge of C and logic
Without C it will be very hard to you, but still you may participate if you have wish.
How do I perform review?
You have to have three sources:
1.0 source code from SVN
1.1 source code from SVN
ioQuake source code
You have to compare equal files and check the logic. Do best as you can. If you don't know what this or that function does or don't understand - don't hesitate to ask (better on IRC channel first). But be sure that almost no one knows whole code, so most of times you'll have to check it by yourself.
I found a bug/collision/missed function/redundant piece of code!
Great. Half of job is done.
Now you have to report it at code subforum in newly created section.
Just create a topic, do a basic explanation what you have found.
If you can - provide a patch how to solve the trouble. If not - suggest a method how to solve. If you don't have clue how to fix it - better to recheck your bug - maybe it is not a bug? Still if nothing helps - just do a report.
What do I get for this?
Nothing.
What are those SVN, IRC, ioQuake3 backport?
Use the search on this forum to find out.
I don't want to and I don't think it is needed, lets save some trouble
No problem. I'm not insisting. Thanks for attention.
When my bug will be fixed?
Will be written in you thread.
I think bugzilla is better than forum?
Me too. Have you found any bugs?
So, there is not many who want to do it, so lets use forum. Also there are a lot of guys who doesn't know how to use bugzilla and I'm not in the mood to write a tut.
I haven't found bug, but I want improvement and the feature?
Code section is open - post your patch there if you done the job.
Or use saloon as usual.
Current post only is about SG 1.1 ioQuake3 backporting review.
There are a lot of things that supposed to be for ioQuake but they alternated in code for SG. To be removed?
Check them closely, compare the ioQuake method and SG one. Maybe we need to create a new one basing on both.
If ioQuake code just needs to be removed it is not a problem - it will be anyway.
Example:
As you can see in ioQuake3 code (orange text) is present cg_crosshairhealth which is really nifty feature to be used in SG. So better to include it (this one is done in crosshair patch, I quoted it here as example).
It is not very easy!
It is very tough job actually. Glad you see it.
That why I want everyone who has wish to do it.
I checked all the code, but I haven't found any bug!
Well, happens. Thanks for help anyway and try again later, there are always something to do.
What do you do Bro?
The same. The patch with bugfixes/improvements.
So, that it.
Thank you for attention!
Hope you'll help with this.
Even a little bug to find is a good job. And you'll be proud yourself for sure, believe me
Have a good day!